Set tabindex
to 0
for skip to content link
#1393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at a few more things and found that the current recommendation for Skip to main content links is to not set tabindex to 1 but to 0 (https://web.dev/control-focus-with-tabindex/) While that is not the ideal solution, it's the one that does not require extra JavaScript. To be 100% correct it would be https://github.com/selfthinker/dokuwiki_template_writr/blob/master/js/skip-link-focus-fix.js