Fix issue where html elements in H1's cause footer layout to be broken #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Released as part of 4.4.1. |
|
Thanks for the quick turn around, now I can remove the partial from our code. |
StanzillaManticore
pushed a commit
to ManticoreGamesInc/mkdocs-material
that referenced
this pull request
Dec 11, 2019
…ken (squidfunk#1217) * Add striptags to next/previous links to eascape invalid html tags * Add generated built files for escaped titles in footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behaviour
When adding a html tags to H1's in markdown files, such as Font awesome icons, the footers next/previous links should look as expected
Current Behaviour
Adding html to H1's in markdown files displays the html correctly in the link itself, but as the H1 is injected into the title attribute of the link, which is invalid as this should not contain html, the layout breaks
Possible Solution
Stripping all html when reading the property in as a Jinja template. This PR addresses the issue in this way.
Steps to Reproduce
fontawesome_markdownextension andawesome-pagesplugin