Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call unregisterConsumer in handleCancel #659

Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 4, 2021

This PR adds a call to unregisterConsumer in handleCancel. This ensures, that the consumer gets removed from this.consumers.

Fixes #585

@kibertoad
Copy link
Collaborator

Can you also add a test for this?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 27, 2021

@kibertoad
I have to see if I can write a unit test. I think when I implemented this I thought that @squaremo would check if the code makes change.

Do you have the permissions to merge?
Alot of stuff we could be improved.

Have a look at #658 . It think this could actually be solve some memory issues as it should potentially not create intermediate arrays.

@kibertoad
Copy link
Collaborator

@Uzlopak I do!

@cressie176 cressie176 merged commit a620933 into amqp-node:main May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak by binding then remove Queue
3 participants