use .push.apply instead of concat in Mux _readIncoming #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused require remove unused self variable
Closed
kibertoad
reviewed
Dec 27, 2021
| @@ -79,7 +77,7 @@ Mux.prototype._readIncoming = function() { | |||
| } | |||
| else { // ran out of room | |||
| assert(this.newStreams.length > 0, "Expect some new streams to remain"); | |||
| this.oldStreams = this.oldStreams.concat(this.newStreams); | |||
| Array.prototype.push.apply(this.oldStreams, this.newStreams); | |||
There was a problem hiding this comment.
Is there a reason why prototype push is used instead of this.oldstreams.push?
There was a problem hiding this comment.
Well I can not test it, but you could do a this.oldstreams.push.apply(this.newstreams)?
I think I did this to make it clear that it does not instantiate a intermediary Array
There was a problem hiding this comment.
https://stackoverflow.com/questions/15444242/why-doesnt-array-push-apply-work
I think this was the reason. I don't want to reference this.oldstreams twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
remove unused require
remove unused self variable
#657
Should reduce memory footprint and performance