Adopt R2DBC changes which do not always send a value #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
changed the title
hfhbd
commented
Sep 22, 2022
| val rowSet = mutableListOf<Map<Int, Any?>>() | ||
| result.map { row, rowMetadata -> | ||
| rowSet.add(rowMetadata.columnMetadatas.mapIndexed { index, _ -> index to row.get(index) }.toMap()) | ||
| }.awaitLast() |
There was a problem hiding this comment.
awaitLast requires at least one item, but this does not work if your result is empty, eg because the query does not return any rows.
dellisd
approved these changes
Sep 22, 2022
AlecKazakova
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new 1.0.0 release does not send a value when executing a sql statement (eg create a database). Instead, the
Publisheris finished without a value, thusawaitSinglefails. Preparation for #3375 which will enable the R2DBC tests.