Add better version catalog support for dialects #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a fixture test for this. I recently added support for type safe project references and type safe dependency references to another project and I didn't have to change anything. However, my line to add the dependency is in this form: project.dependencies.add(configuration.name, theDependencyAnyReferenceHere) |
Add integration test for version catalogs
|
hype! |
AlecKazakova
approved these changes
Aug 12, 2022
|
It looks like some of the other integration tests are failing now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3237
Gradle does a lot of special handling for version catalogs, so I don't think there's any good way to avoid doing that in the plugin as well.Whether we want to specially handle the case where someone hands a dependency bundle to the dialect is another question.