Fix NoSuchFieldError in newer Kotlin plugins #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
reviewed
Aug 7, 2022
| try { | ||
| val instanceField = KotlinTopLevelTypeAliasFqNameIndex::class.java.getField("INSTANCE") | ||
| val instance = instanceField.get(null) | ||
| if (instance is KotlinTopLevelTypeAliasFqNameIndex) { |
There was a problem hiding this comment.
Should not we throw an exception in the else block in case instance is of any type other than KotlinTopLevelTypeAliasFqNameIndex? So if in the future it breaks again, we at least get a proper stacktrace
There was a problem hiding this comment.
hmm, I think that case overall is highly unlikely: <T>.INSTANCE static field exists but is not of type T.
I guess to make it safer we could reflectively check for Companion + getInstance method though and then throw if neither INSTANCE field nor $Companion.getInstance is present?
| } catch (e: Exception) { | ||
| /* intentionally empty, fall back to getInstance() call in case of errors */ | ||
| } | ||
| return KotlinTopLevelTypeAliasFqNameIndex.getInstance() |
There was a problem hiding this comment.
And then this could be moved into the catch block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses an ugly reflection hack to access the
KotlinTopLevelTypeAliasFqNameIndexin the newer Kotlin plugin on IDEA 2022.2 / Kotlin 1.7.x.Fixes #3324