Make OffsetQueryPagingSource only work with Int #3386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking API change! Maybe it's okay as we're releasing SQLDelight 2 soon…
Previously, we're just upcasting
state.anchorPosition
to aLong
, which screws things up when we have betweenInt.MAX_VALUE
andLong.MAX_VALUE
items in our pager. This is because, when we refresh the paging source,getRefreshKey(state: PagingState)
is called, and we'll end up with a very wrongstate.anchorPosition
, as it's no longer the "most recently accessed index in the list", but some truncated form of it. The result ofgetRefresKey(…)
will end up being passed toload(params: LoadParams)
in the form ofparams.key
, and bad things will happen as it's not the value we're expecting.The "fix" is just to force a maximum of
Int.MAX_VALUE
items instead ofLong.MAX_VALUE
. Room does the same thing in their implementation of this class.