Don't do CI builds for obsolete JDKs #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by an accute problem with OpenJDK 10, which
is consistently failing in CI for reasons wholy unrelated to
Okio.
> Configure project :android-test
Unable to detect AGP versions for included builds. All projects in the build should use the same AGP version. Class name for the included build object: org.gradle.composite.internal.DefaultIncludedBuild$IncludedBuildImpl_Decorated.
e: /home/runner/work/okio/okio/android-test/build.gradle.kts:18:1: Unresolved reference: android
It's likely Gradle or AGP or something doesn't work on Java 10,
even though it does work on Java 8, Java 9, Java 11, and Java 12.
I'm not interested in debugging this problem; the right fix for
it is 'Upgrade to a newer JDK'.
I've specifically dropped unmaintained JDKs according to this page:
https://en.wikipedia.org/wiki/Java_version_history
|
From the perspective of OpenJDK, all builds other than 19 are obsolete. There is no intrinsic concept of LTS in the OpenJDK. Vendors can make any version an LTS if they want to. There should really only be a single build JDK, the latest, but multiple test JDKs. |
JakeWharton
approved these changes
Jan 2, 2023
|
I’ve come to think of it like 1.x, 2.x, 3.x, where only major versions get security patches. But instead of 1.x, 2.x, and 3.x, the major versions are inexplicably 8.x, 11.x, and 17.x. |
|
Vendors like Azul support 13.x and 15.x still. Any vendor can backport security patches to any version if they choose to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by an accute problem with OpenJDK 10, which is consistently failing in CI for reasons wholy unrelated to Okio.
It's likely Gradle or AGP or something doesn't work on Java 10, even though it does work on Java 8, Java 9, Java 11, and Java 12.
I'm not interested in debugging this problem; the right fix for it is 'Upgrade to a newer JDK'.
I've specifically dropped unmaintained JDKs according to this page: https://en.wikipedia.org/wiki/Java_version_history