Attempt to make filesystem tests less flaky #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
approved these changes
Jan 1, 2023
| * https://docs.microsoft.com/en-us/windows/win32/sysinfo/file-times | ||
| */ | ||
| private fun Instant.maxFileSystemTime(): Instant { | ||
| return Instant.fromEpochSeconds(plus(2.seconds).epochSeconds) | ||
| val paddedInstant = plus(200.milliseconds) | ||
| return Instant.fromEpochSeconds(paddedInstant.plus(2.seconds).epochSeconds) |
There was a problem hiding this comment.
Why go via epoch seconds?
There was a problem hiding this comment.
It’s attempting to drop precision, consistent with what FAT32 and friends do.
I've been observing failures like this:
expected 2022-12-31T16:00:40.999Z in 2022-12-31T16:00:41Z..2022-12-31T16:00:43Z (relaxed from 2022-12-31T16:00:41.002314Z..2022-12-31T16:00:41.002365Z)
swankjesse
force-pushed
the
jwilson.1231.less_flaky_clocks
branch
from
61c906a
to
06f689e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been observing failures like this: