Add tests for multiple routes #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
reviewed
Dec 23, 2022
swankjesse
reviewed
Dec 23, 2022
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
|
|
||
| @Flaky |
There was a problem hiding this comment.
Is this due to raciness in fast fallback? I wonder if we can add something to make it less racy, like changing the timeouts to MAX_VALUE or 0 or something
There was a problem hiding this comment.
Sorry, not Flaky. I'm just using it for logging the tracing.
swankjesse
approved these changes
Dec 23, 2022
| .assertBody("body") | ||
|
|
||
| assertThat(client.routeDatabase.failedRoutes).isEmpty() | ||
| // TODO check if we expect a second request to server1, before attempting server2 |
There was a problem hiding this comment.
(I think that’s the behavior we should test for, though we could create an issue and change that)
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
|
|
||
| @Flaky |
There was a problem hiding this comment.
Is this due to raciness in fast fallback? I wonder if we can add something to make it less racy, like changing the timeouts to MAX_VALUE or 0 or something
| } | ||
| } | ||
|
|
||
| class SpecificHostSocketFactory( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for IPv4, IPv6 multiple routes. When the RouteDatabase is updated, how many follow up requests are made.