Make it more difficult to accidentally log sensitive headers #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Feb 7, 2021
| @@ -249,6 +249,14 @@ fun String.canParseAsIpAddress(): Boolean { | |||
| return VERIFY_AS_IP_ADDRESS.matches(this) | |||
| } | |||
|
|
|||
| /** Returns true if we should void putting this this header in an exception or toString(). */ | |||
There was a problem hiding this comment.
Suggested change
| /** Returns true if we should void putting this this header in an exception or toString(). */ | |
| /** Returns true if we should void putting this header in an exception or toString(). */ |
yschimke
reviewed
Feb 7, 2021
| @@ -249,6 +249,14 @@ fun String.canParseAsIpAddress(): Boolean { | |||
| return VERIFY_AS_IP_ADDRESS.matches(this) | |||
| } | |||
|
|
|||
| /** Returns true if we should void putting this this header in an exception or toString(). */ | |||
| fun isSensitiveHeader(name: String): Boolean { | |||
There was a problem hiding this comment.
Should this be a public API feature?
There was a problem hiding this comment.
I don’t think so. It’s the sort of thing you don’t know you need until it’s too late.
yschimke
approved these changes
Feb 7, 2021
|
Failing job looks like it's just circleci being woefully under provisioned recently https://app.circleci.com/pipelines/github/square/okhttp/4508/workflows/b41ede5e-98f7-4d2d-9dd4-79e655f4838f/jobs/20469 |
yschimke
pushed a commit
to yschimke/okhttp
that referenced
this pull request
Jul 4, 2021
swankjesse
added a commit
that referenced
this pull request
Jul 4, 2021
3 tasks
tristantarrant
added a commit
to tristantarrant/okhttp
that referenced
this pull request
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.