Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm we can read a response that completed before RST_STREAM #6293

Merged
merged 1 commit into from Oct 2, 2020

Conversation

swankjesse
Copy link
Member

The server can reject the request without breaking the response.

The server can reject the request without breaking the response.
Copy link

@zhxnlai zhxnlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯

@swankjesse swankjesse merged commit 480c20e into master Oct 2, 2020
@swankjesse swankjesse deleted the jwilson.1001.trailers branch October 6, 2020 22:24
oldergod pushed a commit that referenced this pull request Nov 18, 2021
The server can reject the request without breaking the response.

(cherry picked from commit 480c20e)
swankjesse added a commit that referenced this pull request Nov 18, 2021
… (#6914)

The server can reject the request without breaking the response.

(cherry picked from commit 480c20e)

Co-authored-by: Jesse Wilson <jesse@swank.ca>
Crash-- added a commit to Crash--/android-upload-service that referenced this pull request Jul 28, 2023
There is an http2 bug which has been fixed in 4.9.3. 

See https://square.github.io/okhttp/changelogs/changelog_4x/#version-493 

The diff between 4.9.2 and 4.9.3 seems pretty safe square/okhttp#6293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants