Fix build on windows #6257
Merged
Fix build on windows #6257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
windows-1252! |
|
Typical errors
|
JakeWharton
approved these changes
Sep 10, 2020
build.gradle
Outdated
| @@ -123,6 +123,12 @@ subprojects { project -> | |||
| sourceCompatibility = JavaVersion.VERSION_1_8 | |||
| targetCompatibility = JavaVersion.VERSION_1_8 | |||
|
|
|||
| compileJava.options.encoding = 'UTF-8' | |||
There was a problem hiding this comment.
Delete? The second one applies to compileJava as it is a JavaCompile instance.
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See stackoverflow for why this is required, related to the gradle daemon.
https://stackoverflow.com/a/34717160/1542667
I don't currently have any concern that their is a logic bug with string encodings in src/main, but rather that strings in tests are compiled assuming the wrong file encoding, changing the test meaning.