Document interceptor throwing modes #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Aug 24, 2020
| * crashes the application on Android and prints a stacktrace on the JVM. (Crash reporting | ||
| * libraries may customize this behavior.) | ||
| * | ||
| * A good way to signal a failure is with a synthetic HTTP response: |
There was a problem hiding this comment.
Is the idea that IOException should be purely the domain of connectivity issues?
There was a problem hiding this comment.
Not exclusively, but synthetic failures are a good option to call out.
yschimke
approved these changes
Aug 24, 2020
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.