Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android Platform init #6073

Merged
merged 1 commit into from May 20, 2020
Merged

Fix Android Platform init #6073

merged 1 commit into from May 20, 2020

Conversation

yschimke
Copy link
Collaborator

The Platform Companion ordering means that a Boolean field and the Platform instance field can race.

@yschimke
Copy link
Collaborator Author

Fixes #6069

@yschimke
Copy link
Collaborator Author

The tests hide this because of specific ordering

image

@yschimke yschimke mentioned this pull request May 20, 2020
Closed
@yschimke yschimke added this to the 4.7.2 milestone May 20, 2020
@swankjesse swankjesse merged commit b733d29 into square:master May 20, 2020
@yschimke yschimke deleted the android_init_ordering branch October 30, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse Awaiting requested review from swankjesse

@JakeWharton JakeWharton Awaiting requested review from JakeWharton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yschimke @swankjesse