Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Call.Factory a function interface in Kotlin 1.4 #6014

Closed
ZacSweers opened this issue May 2, 2020 · 5 comments
Closed

Make Call.Factory a function interface in Kotlin 1.4 #6014

ZacSweers opened this issue May 2, 2020 · 5 comments
Labels
enhancement Feature not a bug
Milestone
4.9

Comments

@ZacSweers
Copy link
Contributor

ZacSweers commented May 2, 2020 •
edited

Feature request that I wanted to file for the future.

fun interface Factory {
  fun newCall(request: Request): Call
}

Then it could be used as a lambda with 1.4's SAM support

Retrofit.Builder()
  .callFactory { ... }
@ZacSweers ZacSweers added the enhancement Feature not a bug label May 2, 2020
@yschimke
Copy link
Collaborator

yschimke commented May 3, 2020

Good call, I'll add to #5947

@ZacSweers
Copy link
Contributor Author

The same could go for Interceptor I suppose too!

@yschimke
Copy link
Collaborator

yschimke commented May 3, 2020

Any view of this list? 9eccc9f

@ZacSweers
Copy link
Contributor Author

I like it!

@yschimke
Copy link
Collaborator

yschimke commented May 3, 2020

And cleanup d58b5b2

e.g.

image

@yschimke yschimke added this to the 4.8 milestone May 3, 2020
@yschimke yschimke closed this as completed Sep 9, 2020
@yschimke yschimke modified the milestones: 4.8, 4.9 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature not a bug
Projects
None yet
Milestone
4.9
Development

No branches or pull requests
2 participants
@yschimke @ZacSweers