Flag connection as unhealthy when underlying socket is closed. #5920
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this reproduces the issue reported in #5819. This is very subtle. I found that if we close the |
dave-r12
force-pushed
the
health-raw-socket
branch
from
1a98d78
to
11ee29c
Compare
swankjesse
approved these changes
Apr 4, 2020
| val socket = this.socket!! | ||
| val source = this.source!! | ||
| if (socket.isClosed || socket.isInputShutdown || socket.isOutputShutdown) { | ||
| if (rawSocket.isClosed || socket.isClosed || socket.isInputShutdown || |
|
Impressive detective work. |
|
I wonder whether this could solve a whole bunch of problems after network changes etc. I'm glad this made 4.5! |
This was referenced Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5819