Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .use() writing metadata to the cache #5793

Merged
merged 1 commit into from Feb 17, 2020
Merged

Use .use() writing metadata to the cache #5793

merged 1 commit into from Feb 17, 2020

Conversation

swankjesse
Copy link
Member

No description provided.

yschimke
yschimke approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

oldergod
oldergod approved these changes Feb 17, 2020
View reviewed changes
okhttp/src/main/java/okhttp3/Cache.kt
sink.writeDecimalLong(varyHeaders.size.toLong()).writeByte('\n'.toInt())
for (i in 0 until varyHeaders.size) {
sink.writeUtf8(varyHeaders.name(i))
editor.newSink(ENTRY_METADATA).buffer().use { sink ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@swankjesse swankjesse merged commit 54a6c66 into master Feb 17, 2020
@oldergod oldergod deleted the jwilson.0216.reliably_release branch February 17, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

@oldergod oldergod oldergod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swankjesse @yschimke @oldergod