Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JUnit 4.13 #4683

Closed
amirlivneh opened this issue Mar 4, 2019 · 2 comments
Closed

Upgrade to JUnit 4.13 #4683

amirlivneh opened this issue Mar 4, 2019 · 2 comments
Labels
tests Fix relates to tests not code
Milestone
4.4

Comments

@amirlivneh
Copy link
Collaborator

I'm specifically interested in the fix for junit-team/junit4#1517, which affects OkHttp tests that use a Timeout rule.
@amirlivneh amirlivneh added enhancement Feature not a bug tests Fix relates to tests not code and removed enhancement Feature not a bug labels Mar 4, 2019
@JakeWharton
Copy link
Member

Yes please! I think we'd all be comfortable using beta 2 since it's only test APIs. I wouldn't force it onto our consumers in MockWebServer until stable, though.

@swankjesse swankjesse added this to the Backlog milestone Apr 13, 2019
@monkey-mas monkey-mas mentioned this issue Jun 16, 2019
Closed
@swankjesse
Copy link
Member

Fixed with https://github.com/square/okhttp/pull/5718/files

@swankjesse swankjesse modified the milestones: Backlog, 4.4 Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Fix relates to tests not code
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
3 participants
@JakeWharton @swankjesse @amirlivneh