Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility in LeakCanary 3.0 alpha 1 #2617

Open
pyricau opened this issue Jan 9, 2024 · 0 comments
Open

Fix backward compatibility in LeakCanary 3.0 alpha 1 #2617

pyricau opened this issue Jan 9, 2024 · 0 comments

Comments

@pyricau
Copy link
Member

pyricau commented Jan 9, 2024

  • DeletableObjectReporter isn't a fun interface so custom code that was passing a lambda to watchers now has to pass object : DeletableObjectReporter. This should be an easy fix, just add some fun.
  • RootViewWatcher now has a required watchDismissedDialogs field. Let's provide a default value.
  • DeletableObjectReporter must return a TrackedObjectReachability. That's not backward compatible. Not easy to implement when delegating to AppWatcher.objectWatcher.expectWeaklyReachable(target, reason), and even if switching to expectDeletionFor we need to handle the case where we actually want to skip and not delegate. Best seems to provide to versions of the method, one of which doesn't return a TrackedObjectReachability. That'll make things easier for the ReachabilityWatcher implementation as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant