Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable leakcanary-android-release for API 32-33 #2462

Open
atoropov opened this issue Jan 12, 2023 · 1 comment
Open

Enable leakcanary-android-release for API 32-33 #2462

atoropov opened this issue Jan 12, 2023 · 1 comment

Comments

@atoropov
Copy link

Currently on API 30+ leak canary for release is blocked by this code:
https://github.com/square/leakcanary/blob/main/leakcanary-android-release/src/main/java/leakcanary/GoodAndroidVersionInterceptor.kt

But seems like issue of app being freezed when heap analysis starts has been fixed for API 32+ (didn't find the exact information, but I don't have this issue anymore on my Pixel 4a, but I had it before). So maybe it's time to unblock leakcanary for more API levels.

@pyricau
Copy link
Member

pyricau commented Jan 23, 2023

Interesting suggestion, we should test it out. Let me know if you do test it out and find out it works fine at larger scale.

Btw the list of interceptor can be whatever you want, you don't have to use GoodAndroidVersionInterceptor you can roll your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants