Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upgrade Android Gradle Plugin to 7.3.1 with newest Leak Canary 2.10 #2461

Open
pkrawczykObj opened this issue Jan 9, 2023 · 8 comments
Milestone

Comments

@pkrawczykObj
Copy link

Description

After upgrading Android Gradle Plugin to 7.3.1 I receive following build error:

The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher.
The following dependencies do not satisfy the required version:
project ':app' -> com.squareup.leakcanary:leakcanary-deobfuscation-gradle-plugin:2.10 -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.21

Steps to Reproduce

  1. Upgrade Android Gradle Plugin to 7.3.1
  2. Build app
  3. Error from description appears.

Expected behavior: Application compiles with no error.

Version Information

  • LeakCanary version: 2.10
  • Android OS version: n/a
  • Gradle version: 7.3.1
@pyricau
Copy link
Member

pyricau commented Jan 23, 2023

The original contributor is @mzgreen, and @Goooler made a few changes over time. I mostly haven't touched this plugin so not a great person to fix. You're also welcome to contribute a fix.

@Goooler
Copy link
Contributor

Goooler commented Jan 24, 2023

This is a warning, build passed. Might be time to upgrade Kotlin version of LC.

@pyricau
Copy link
Member

pyricau commented Jan 24, 2023

Definitely plan on bumping but for LeakCanary 3, I've been sticking to the same version of Kotlin for all of LeakCanary 2.x

@pyricau
Copy link
Member

pyricau commented Jan 24, 2023

but you're saying "Kotlin Gradle plugin version 1.5.20" implies "kotlin compiler 1.5" ?

@Goooler
Copy link
Contributor

Goooler commented Jan 24, 2023

That's a check from AGP.

@pkrawczykObj
Copy link
Author

This is a warning, build passed. Might be time to upgrade Kotlin version of LC.

No it is an error in my project and it unabled to compile the app.
image

but you're saying "Kotlin Gradle plugin version 1.5.20" implies "kotlin compiler 1.5" ?

I mean this: https://plugins.gradle.org/plugin/org.jetbrains.kotlin.android. Currently you are using version 1.4.21 from December 2020. It is defined in line 18 in file "gradle/libs.versions.toml" (51cdeca)

@Goooler
Copy link
Contributor

Goooler commented Jan 24, 2023

Do you apply the newer KGP in you classpath? It works well in my project with KGP 1.8.0 & AGP 7.4.0, see https://github.com/Goooler/DemoApp

@pyricau pyricau added this to the 3.0 milestone May 18, 2023
@pyricau
Copy link
Member

pyricau commented May 18, 2023

Will upgrade a bunch of things for 3.0 so this will hopefully go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants