Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when exploring an HeapDump #2371

Closed
Tolriq opened this issue Apr 22, 2022 · 3 comments · Fixed by #2373
Closed

Crash when exploring an HeapDump #2371

Tolriq opened this issue Apr 22, 2022 · 3 comments · Fixed by #2373
Milestone

Comments

@Tolriq
Copy link

Tolriq commented Apr 22, 2022

Description

Got a crash with 2.9.1 but can't reproduce again for now. Reporting in case there's something to look into.

Steps to Reproduce

Not 100% sure was while navigating inside an HeapDump or while leaving the heap dump screen. Can't reproduce despite many attempts.

Version Information

  • LeakCanary version: 2.9.1
  • Android OS version: 12
  • Gradle version: 7.4.2

Additional Information

Log:

java.lang.IllegalStateException: Already closed
	at leakcanary.internal.activity.db.ScopedLeaksDb$DbOpener.checkClosed(ScopedLeaksDb.kt:69)
	at leakcanary.internal.activity.db.ScopedLeaksDb$DbOpener.getWritableDatabase(ScopedLeaksDb.kt:51)
	at leakcanary.internal.activity.db.Db$execute$1.invoke(Db.kt:35)
	at leakcanary.internal.activity.db.Db$execute$1.invoke(Db.kt:9)
	at leakcanary.internal.activity.db.Io$execute$2.invoke(Io.kt:44)
	at leakcanary.internal.activity.db.Io$execute$2.run(Io.kt:10)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:920)
@pyricau
Copy link
Member

pyricau commented Apr 22, 2022

Thanks! You just found a major crash, the UI only allows opening the db once.

Repro:

  • Go to leaks
  • Press back so that activity gets destroyed
  • Go to leaks again => crash.

@pyricau pyricau added this to the 2.10 milestone Apr 22, 2022
pyricau added a commit that referenced this issue Apr 22, 2022
@Tolriq
Copy link
Author

Tolriq commented Apr 22, 2022

Nice is it worth a chocolate Cookie ? :)

I also just got some OOM during heap analysis, do you want an issue!? (Probably due to my app currently consuming wayy too much memory)

@dmytroKarataiev
Copy link

We're having the same crash, let me know if you need more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants