Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple devices for Shark CLI #1642

Closed
pyricau opened this issue Nov 26, 2019 · 1 comment · Fixed by #1645
Closed

Support multiple devices for Shark CLI #1642

pyricau opened this issue Nov 26, 2019 · 1 comment · Fixed by #1645
Labels
type: enhancement
Milestone
2.0

Comments

@pyricau
Copy link
Member

pyricau commented Nov 26, 2019

Problem description

Currently Shark CLI runs adb directly without any -s parameter. We should support that and pass it through. Ideally the library should detect when there are multiple devices connected and suggest using a -s parameter.
@pyricau
Copy link
Member Author

pyricau commented Nov 26, 2019

Source: https://stackoverflow.com/questions/58999359/how-to-use-shark-cli-library-with-2-usb-connected-devices

pyricau added a commit that referenced this issue Nov 27, 2019
@pyricau
Multiple connected devices in Shark CLI
ab98ac5 
* Refactored argument parsing with improved error handling.
* Changed argument format to allow for shorthand (-p, -d)
* New argument -d or --device to pass in targeted device.

Fixes #1642
@pyricau pyricau mentioned this issue Nov 27, 2019
Merged
@pyricau pyricau added this to the 2.0 Next Release milestone Nov 27, 2019
pyricau added a commit that referenced this issue Nov 27, 2019
@pyricau
Multiple connected devices in Shark CLI (#1645)
e4db0e7 
* Refactored argument parsing with improved error handling.
* Changed argument format to allow for shorthand (-p, -d)
* New argument -d or --device to pass in targeted device.

Fixes #1642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Multiple connected devices in Shark CLI square/leakcanary
1 participant
@pyricau