Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the version of the app. #1528

Closed
BraisGabin opened this issue Aug 11, 2019 · 4 comments
Closed

Show the version of the app. #1528

BraisGabin opened this issue Aug 11, 2019 · 4 comments

Comments

@BraisGabin
Copy link
Contributor

It would be great to display the version/s of the app where the leaks are found. This way you can find regresions or don't bother with leaks that not longer exist if you go on a "Leakathon". The time is kind of ok but I usually install old versions of the app so it can be a bit messy.

@pyricau
Copy link
Member

pyricau commented Aug 12, 2019

Thanks for the feature request!

How often do you update the app version? Would you surface app version name or app version code?

I think we would ideally surface this in the data structures as well as UI (post redesign #1445, in the info block)

That being said, there's also a plan to add support for any kind of metadata (#1519). If this information is in the heap dump then we might leave it to the library user to add this.

@BraisGabin
Copy link
Contributor Author

How often do you update the app version?

It depends. Lately I'm looking for a lot of regresions so very often. Twice per day?

Would you surface app version name or app version code?

Probably both.

That being said, there's also a plan to add support for any kind of metadata (#1519). If this information is in the heap dump then we might leave it to the library user to add this.

This have a lot of sense. But parsing the heap sounds a bit scary. Do I need to find the mem position where Android stores the string with the version name of the app?

If we add a metadata section probably add the version name and version code as default values would be perfect. It's useful information but you don't need it all the time so probably it's not worth it to add more information the the current views.

@pyricau
Copy link
Member

pyricau commented Nov 14, 2019

I've been searching for the version name string and it's not available out of the box in memory (unless the app package). Therefore I don't think there's much value in providing it by requesting it from the package manager for all users, but instance we'll provide a map API so that anyone can add anything.

@pyricau
Copy link
Member

pyricau commented Nov 14, 2019

The next release will enable you to add this, and the docs have a recipe for adding app version details.

@pyricau pyricau closed this as completed Nov 14, 2019
@pyricau pyricau added this to the 2.0 Next Release milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants