Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding hprof metadata into heap analysis #1519

Closed
pyricau opened this issue Jul 31, 2019 · 0 comments
Closed

Support for adding hprof metadata into heap analysis #1519

pyricau opened this issue Jul 31, 2019 · 0 comments

Comments

@pyricau
Copy link
Member

pyricau commented Jul 31, 2019

At Square we upload the heap analysis results. Having extra general information about the state of the app can help (e.g. session token, navigation log, etc). All that information is available in the heap. Right now the only to get that is by parsing the hprof again post analysis. Instead, we should provide a hook in LeakCanary to add metadata, and retrieve it from the heap analysis itself.

We should probably stick to a Map<String, String> because HeapAnalysis needs to be serializable and printable as string.

@pyricau pyricau modified the milestones: 2.0 Next Release, 2.0-beta-2 Jul 31, 2019
@pyricau pyricau removed this from the 2.0 Next Release milestone Aug 22, 2019
pyricau added a commit that referenced this issue Sep 11, 2019
@pyricau pyricau added this to the 2.0 Next Release milestone Sep 11, 2019
pyricau added a commit that referenced this issue Nov 14, 2019
pyricau added a commit that referenced this issue Nov 14, 2019
pyricau added a commit that referenced this issue Nov 14, 2019
pyricau added a commit that referenced this issue Nov 14, 2019
pyricau added a commit that referenced this issue Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant