From dbd9be8e40389d8e2e0aa0889baf697ee97493f4 Mon Sep 17 00:00:00 2001
From: PY <pyricau@users.noreply.github.com>
Date: Tue, 10 Sep 2019 18:51:19 -0700
Subject: [PATCH] PR feedback (#1574)

https://github.com/square/leakcanary/pull/1570#discussion_r322547845
---
 shark/src/main/java/shark/ReferencePattern.kt | 21 ++++++++-----------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/shark/src/main/java/shark/ReferencePattern.kt b/shark/src/main/java/shark/ReferencePattern.kt
index 4482412651..eb17d5edd7 100644
--- a/shark/src/main/java/shark/ReferencePattern.kt
+++ b/shark/src/main/java/shark/ReferencePattern.kt
@@ -13,9 +13,7 @@ sealed class ReferencePattern : Serializable {
   data class JavaLocalPattern(
     val threadName: String
   ) : ReferencePattern() {
-    override fun toString(): String {
-      return "local variable on thread $threadName"
-    }
+    override fun toString() = "local variable on thread $threadName"
   }
 
   /**
@@ -25,9 +23,7 @@ sealed class ReferencePattern : Serializable {
     val className: String,
     val fieldName: String
   ) : ReferencePattern() {
-    override fun toString(): String {
-      return "static field $className#$fieldName"
-    }
+    override fun toString() = "static field $className#$fieldName"
   }
 
   /**
@@ -42,14 +38,15 @@ sealed class ReferencePattern : Serializable {
     val className: String,
     val fieldName: String
   ) : ReferencePattern() {
-    override fun toString(): String {
-      return "instance field $className#$fieldName"
-    }
+    override fun toString() = "instance field $className#$fieldName"
   }
 
+  /**
+   * Matches native global variables (also known as jni global gc roots) that reference
+   * Java objects. The class name will match against classes, instances and object arrays with
+   * a matching class name.
+   */
   data class NativeGlobalVariablePattern(val className: String) : ReferencePattern() {
-    override fun toString(): String {
-      return "native global variable referencing $className"
-    }
+    override fun toString() = "native global variable referencing $className"
   }
 }
\ No newline at end of file