From 3352c2b8ce8aa88a0c217d1da78ef5fea3b7e5b4 Mon Sep 17 00:00:00 2001 From: PY Date: Wed, 27 Nov 2019 11:16:44 -0800 Subject: [PATCH] Updating icons (#1648) --- .../java/leakcanary/internal/Notifications.kt | 2 +- .../internal/activity/LeakActivity.kt | 44 +++++---- .../res/color/leak_canary_bottom_menu.xml | 2 +- .../leak_canary_notification.xml | 38 -------- .../leak_canary_notification.png | Bin 557 -> 0 bytes .../leak_canary_notification.png | Bin 384 -> 0 bytes .../leak_canary_notification.png | Bin 746 -> 0 bytes .../leak_canary_notification.png | Bin 1084 -> 0 bytes .../main/res/drawable/leak_canary_dump.xml | 22 +++++ .../main/res/drawable/leak_canary_info.xml | 5 + .../main/res/drawable/leak_canary_leak.xml | 30 ++++++ .../res/drawable/leak_canary_notification.xml | 14 --- .../res/layout/leak_canary_leak_activity.xml | 89 ++++++++++++++---- .../main/res/values/leak_canary_colors.xml | 2 +- 14 files changed, 159 insertions(+), 89 deletions(-) delete mode 100644 leakcanary-android-core/src/main/res/drawable-anydpi-v24/leak_canary_notification.xml delete mode 100644 leakcanary-android-core/src/main/res/drawable-hdpi/leak_canary_notification.png delete mode 100644 leakcanary-android-core/src/main/res/drawable-mdpi/leak_canary_notification.png delete mode 100644 leakcanary-android-core/src/main/res/drawable-xhdpi/leak_canary_notification.png delete mode 100644 leakcanary-android-core/src/main/res/drawable-xxhdpi/leak_canary_notification.png create mode 100644 leakcanary-android-core/src/main/res/drawable/leak_canary_dump.xml create mode 100644 leakcanary-android-core/src/main/res/drawable/leak_canary_info.xml create mode 100644 leakcanary-android-core/src/main/res/drawable/leak_canary_leak.xml delete mode 100644 leakcanary-android-core/src/main/res/drawable/leak_canary_notification.xml diff --git a/leakcanary-android-core/src/main/java/leakcanary/internal/Notifications.kt b/leakcanary-android-core/src/main/java/leakcanary/internal/Notifications.kt index a636bea29e..2c0b12af5d 100644 --- a/leakcanary-android-core/src/main/java/leakcanary/internal/Notifications.kt +++ b/leakcanary-android-core/src/main/java/leakcanary/internal/Notifications.kt @@ -66,7 +66,7 @@ internal object Notifications { builder: Notification.Builder, type: NotificationType ): Notification { - builder.setSmallIcon(R.drawable.leak_canary_notification) + builder.setSmallIcon(R.drawable.leak_canary_leak) .setWhen(System.currentTimeMillis()) if (SDK_INT >= O) { diff --git a/leakcanary-android-core/src/main/java/leakcanary/internal/activity/LeakActivity.kt b/leakcanary-android-core/src/main/java/leakcanary/internal/activity/LeakActivity.kt index d90e958ee5..fd3842104d 100644 --- a/leakcanary-android-core/src/main/java/leakcanary/internal/activity/LeakActivity.kt +++ b/leakcanary-android-core/src/main/java/leakcanary/internal/activity/LeakActivity.kt @@ -3,19 +3,17 @@ package leakcanary.internal.activity import android.app.PendingIntent import android.content.Context import android.content.Intent -import android.graphics.Typeface import android.net.Uri import android.os.AsyncTask import android.os.Bundle import android.view.View -import android.widget.TextView import com.squareup.leakcanary.core.R import leakcanary.internal.HeapAnalyzerService import leakcanary.internal.InternalLeakCanary import leakcanary.internal.activity.db.Db import leakcanary.internal.activity.screen.AboutScreen -import leakcanary.internal.activity.screen.LeaksScreen import leakcanary.internal.activity.screen.HeapDumpsScreen +import leakcanary.internal.activity.screen.LeaksScreen import leakcanary.internal.navigation.NavigatingActivity import leakcanary.internal.navigation.Screen import shark.SharkLog @@ -25,15 +23,27 @@ import java.io.IOException internal class LeakActivity : NavigatingActivity() { private val leaksButton by lazy { - findViewById(R.id.leak_canary_navigation_button_leaks) + findViewById(R.id.leak_canary_navigation_button_leaks) + } + + private val leaksButtonIconView by lazy { + findViewById(R.id.leak_canary_navigation_button_leaks_icon) } private val heapDumpsButton by lazy { - findViewById(R.id.leak_canary_navigation_button_heap_dumps) + findViewById(R.id.leak_canary_navigation_button_heap_dumps) + } + + private val heapDumpsButtonIconView by lazy { + findViewById(R.id.leak_canary_navigation_button_heap_dumps_icon) } private val aboutButton by lazy { - findViewById(R.id.leak_canary_navigation_button_about) + findViewById(R.id.leak_canary_navigation_button_about) + } + + private val aboutButtonIconView by lazy { + findViewById(R.id.leak_canary_navigation_button_about_icon) } private val bottomNavigationBar by lazy { @@ -52,33 +62,33 @@ internal class LeakActivity : NavigatingActivity() { } override fun onNewScreen(screen: Screen) { - when(screen) { + when (screen) { is LeaksScreen -> { bottomNavigationBar.visibility = View.VISIBLE leaksButton.isSelected = true - leaksButton.setTypeface(null, Typeface.BOLD) + leaksButtonIconView.alpha = 1.0f heapDumpsButton.isSelected = false - heapDumpsButton.setTypeface(null, Typeface.NORMAL) + heapDumpsButtonIconView.alpha = 0.4f aboutButton.isSelected = false - aboutButton.setTypeface(null, Typeface.NORMAL) + aboutButtonIconView.alpha = 0.4f } is HeapDumpsScreen -> { bottomNavigationBar.visibility = View.VISIBLE leaksButton.isSelected = false - leaksButton.setTypeface(null, Typeface.NORMAL) + leaksButtonIconView.alpha = 0.4f heapDumpsButton.isSelected = true - heapDumpsButton.setTypeface(null, Typeface.BOLD) + heapDumpsButtonIconView.alpha = 1.0f aboutButton.isSelected = false - aboutButton.setTypeface(null, Typeface.NORMAL) + aboutButtonIconView.alpha = 0.4f } is AboutScreen -> { bottomNavigationBar.visibility = View.VISIBLE leaksButton.isSelected = false - leaksButton.setTypeface(null, Typeface.NORMAL) + leaksButtonIconView.alpha = 0.4f heapDumpsButton.isSelected = false - heapDumpsButton.setTypeface(null, Typeface.NORMAL) + heapDumpsButtonIconView.alpha = 0.4f aboutButton.isSelected = true - aboutButton.setTypeface(null, Typeface.BOLD) + aboutButtonIconView.alpha = 1.0f } else -> { bottomNavigationBar.visibility = View.GONE @@ -108,7 +118,7 @@ internal class LeakActivity : NavigatingActivity() { returnIntent: Intent? ) { SharkLog.d { - "Got activity result with requestCode=$requestCode resultCode=$resultCode returnIntent=$returnIntent" + "Got activity result with requestCode=$requestCode resultCode=$resultCode returnIntent=$returnIntent" } if (requestCode == FILE_REQUEST_CODE && resultCode == RESULT_OK && returnIntent != null) { returnIntent.data?.let { fileUri -> diff --git a/leakcanary-android-core/src/main/res/color/leak_canary_bottom_menu.xml b/leakcanary-android-core/src/main/res/color/leak_canary_bottom_menu.xml index 9e5d7ba3fe..65197a4eb3 100644 --- a/leakcanary-android-core/src/main/res/color/leak_canary_bottom_menu.xml +++ b/leakcanary-android-core/src/main/res/color/leak_canary_bottom_menu.xml @@ -1,5 +1,5 @@ - + diff --git a/leakcanary-android-core/src/main/res/drawable-anydpi-v24/leak_canary_notification.xml b/leakcanary-android-core/src/main/res/drawable-anydpi-v24/leak_canary_notification.xml deleted file mode 100644 index f5f88aa7a5..0000000000 --- a/leakcanary-android-core/src/main/res/drawable-anydpi-v24/leak_canary_notification.xml +++ /dev/null @@ -1,38 +0,0 @@ - - - - - - - - - - - - - diff --git a/leakcanary-android-core/src/main/res/drawable-hdpi/leak_canary_notification.png b/leakcanary-android-core/src/main/res/drawable-hdpi/leak_canary_notification.png deleted file mode 100644 index b3fe4bcc096c87f985df4c71a013dd930315cf32..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 557 zcmV+|0@D47P)Nkl{ZL~SCNpX@SDai>X2T`k74o(_46?(5gQH~ao?EtY7aF*t;f9MJk#WYT~K^qMJ= z0pdX-*dpKQ0=b~mD2a0522bQS7vPP(r(%B47HN?^PX<(nWh z5bDQq*Fc#A+9E;;H5w#y32aKXk63UPVHqzdRcPfT$Enb~OKESA&LxPkTt(+raG=q0m_#Jv5muPKm0Q2lrA{Re9 v$Mt}0qYjofP)*PLY@t$WK~ePIkbj>q3qZ{~{cCA+00000NkvXXu0mjfv$*d` diff --git a/leakcanary-android-core/src/main/res/drawable-mdpi/leak_canary_notification.png b/leakcanary-android-core/src/main/res/drawable-mdpi/leak_canary_notification.png deleted file mode 100644 index 9843dc0439f57e0c338f9fe938f2a78ebd5770e3..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 384 zcmV-`0e}99P)4WDyaR|oK>1g2=u-ybZXkXGRi}x|0)I4@?*h37h>t`0ARkC0 zIR>PDI}rav(gX4-2ULv#5a%IVFz-JmScAq-1LA5Re)JzZI1R)NKztL*-;Qj-ng4{r z@BgHMHe?IV{iiA0 z%YV|rYfv(xz+MF)?f~LfKwM6)A?`>aiw-^m@i9Cem_mkqOrTf;;w?b@7s;%6avU!L z#P9Gp@B|QxK|OL3i+mpmc7e<(hn8a4fIB%J=p~Ru)&Vgy5OV;rCJ=wal7x5(*kKLC z%YgU?0lO6On4yeKkOhd};xX_$5W4}f2@uEPQ5TEFY#t!a1ma6X=A}p2YI`8=2FU^O zUThw)BGT}E(9DJlEJG`TK}GH-5(|SxQ2ly9+ybg+(Bx-h^FRy<7F@w22g)0fKz!ss z`CtPOU&AAxkIe(^|EUB1{HHxI!RCQU|Az*6i?yi&6igf<9+-!#Xwn%X9&p3u0RbTX zH^?0iYAiD1t7NVWau1{ts);8KV#nVg*iZy2@E^n;@FS)z#1F(@2chGalG31?F~}VM z5LCdB;sMP;R2qSr?FQsDtG5pV$Ah}5UgY-5Oz706K?fh89V$>i!<*8MbvKS!A2|S2Nc01-G!V~% zmNZJV8Xt;48!ezFcmp+`k=BD;1vJhFccEQJV_JHmnualfo~aK&+hr+0?0|+@De;6q z869+L0nkWc7`4VsZw^2|K!=*i2{f=(MTgk<1|1n^qgB2T2aVCtpw8vobZ&PP ci~{Na067Z`uMp+MmH+?%07*qoM6N<$f>MM&g8%>k diff --git a/leakcanary-android-core/src/main/res/drawable-xxhdpi/leak_canary_notification.png b/leakcanary-android-core/src/main/res/drawable-xxhdpi/leak_canary_notification.png deleted file mode 100644 index e27d8a18174294c6607ada344238d0df0ac7b11d..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1084 zcmV-C1jGA@P)_#z7P`@p*`NeGV&U}^w1hc+3oHVD{`xiO>n3Ang6qt< z0wJ%DxW$-0;2`+TtW}BweV+ghfm*v77!2x|^?G9SKQt56gI~P8TDuymXZEPjhW?HO zJ0pyLr|dAOM8_At0^-BWT;cSGZhZ^;IUigA9Z}jWw%VLoI>(#_eq9-leQF~7C%d%F zWd8<%Efia6>|dVM23^zn$h-k@Ux9k;V#a-tr2 z8{h-T6rm(cdSiv1{8}q`Ji-fd*)*-Z&3ZMJw(s6>v6t&Zqb^QA{cmcb7J0Nlk%B$r7BLSl?T2)1!cBH+T5fproSvs6rDAcb~RwqRPeAD8AAnM zo1K2#sGjgJ_$jzKlr2r}$-$d~xH|$G^AT(mDHOm*0B#8QBnALm@<+P|m zcDLySy~B^*aq!AUQ)sP7Kfqb%$n0dJS#!aDzR)zgIpF8ZjciAAKn@!=iFP`{UKaeh zK^0GD`1pWNe{1;hqhKqT$5g85rKF^!q@<*zBIqxF1a8-@e))F*0000 + + + + diff --git a/leakcanary-android-core/src/main/res/drawable/leak_canary_info.xml b/leakcanary-android-core/src/main/res/drawable/leak_canary_info.xml new file mode 100644 index 0000000000..694aa9abd6 --- /dev/null +++ b/leakcanary-android-core/src/main/res/drawable/leak_canary_info.xml @@ -0,0 +1,5 @@ + + + diff --git a/leakcanary-android-core/src/main/res/drawable/leak_canary_leak.xml b/leakcanary-android-core/src/main/res/drawable/leak_canary_leak.xml new file mode 100644 index 0000000000..9bf97331f7 --- /dev/null +++ b/leakcanary-android-core/src/main/res/drawable/leak_canary_leak.xml @@ -0,0 +1,30 @@ + + + + + + diff --git a/leakcanary-android-core/src/main/res/drawable/leak_canary_notification.xml b/leakcanary-android-core/src/main/res/drawable/leak_canary_notification.xml deleted file mode 100644 index 3fe6f4824c..0000000000 --- a/leakcanary-android-core/src/main/res/drawable/leak_canary_notification.xml +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - - - - - - diff --git a/leakcanary-android-core/src/main/res/layout/leak_canary_leak_activity.xml b/leakcanary-android-core/src/main/res/layout/leak_canary_leak_activity.xml index e6c01fda74..a385b35d69 100644 --- a/leakcanary-android-core/src/main/res/layout/leak_canary_leak_activity.xml +++ b/leakcanary-android-core/src/main/res/layout/leak_canary_leak_activity.xml @@ -14,40 +14,95 @@ - - + + + + + + - + + + + + + > + + + \ No newline at end of file diff --git a/leakcanary-android-core/src/main/res/values/leak_canary_colors.xml b/leakcanary-android-core/src/main/res/values/leak_canary_colors.xml index 6996c6be20..c75e38ae52 100644 --- a/leakcanary-android-core/src/main/res/values/leak_canary_colors.xml +++ b/leakcanary-android-core/src/main/res/values/leak_canary_colors.xml @@ -26,7 +26,7 @@ #939CA3 #2F2F2F #151C1F - #c1151C1F + #66151C1F #40151C1F #ffffff #ffd40b