Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addModifiers(Iterable) for TypeSpec.Builder #841

Open
h908714124 opened this issue May 20, 2021 · 3 comments
Open

addModifiers(Iterable) for TypeSpec.Builder #841

h908714124 opened this issue May 20, 2021 · 3 comments

Comments

@h908714124
Copy link

h908714124 commented May 20, 2021

MethodSpec.Builder has two versions of the addModifiers method:

public Builder addModifiers(Modifier... modifiers) {...}
public Builder addModifiers(Iterable<Modifier> modifiers) {...}

but TypeSpec.Builder has only one of these.
This is counterintuitive.

@JakeWharton
Copy link
Member

Yep, easy fix! Want to send a PR?

@h908714124
Copy link
Author

@JakeWharton thanks, I'll leave it to someone who has signed the CLA

@BigJIU
Copy link

BigJIU commented Apr 20, 2022

I have sent PR #873 , and just signed the CLA. Wish it could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants