Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeVariableName#annotated lost previously annotated annotations #826

Open
anatawa12 opened this issue Feb 21, 2021 · 2 comments
Open

TypeVariableName#annotated lost previously annotated annotations #826

anatawa12 opened this issue Feb 21, 2021 · 2 comments

Comments

@anatawa12
Copy link

anatawa12 commented Feb 21, 2021

I found that TypeName#annotated keeps previously annotated annotations, but TypeVariableName#annotated lost that.

  public TypeName annotated(List<AnnotationSpec> annotations) {
    Util.checkNotNull(annotations, "annotations == null");
    return new TypeName(keyword, concatAnnotations(annotations));
  }
  @Override public TypeVariableName annotated(List<AnnotationSpec> annotations) {
    return new TypeVariableName(name, bounds, annotations);
  }

I found this in Resolving #825. I'm adding ? extends for each List<SomeType> but because of this, it's not possible.

@CharlotteE67
Copy link

Our group are interested in this issue, we will try to fix it.
---- SE_Sustech

@XaviaXu
Copy link

XaviaXu commented Apr 24, 2021

This issue has been fixed and the PR is #835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants