Fix TypeName.get() on top-level error types #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I noticed: if there's a type that can be resolved that has type parameters, javac seems to give a TypeMirror that's simple name is I imagine that that was never supported (I don't see any way to get out of that), but maybe that means we should throw on ErrorTypes? That would be a behavioral change though, and it's not clear to me that that's what we should do. |
swankjesse
approved these changes
May 9, 2018
| default: | ||
| throw new IllegalArgumentException("unexpected type nesting"); | ||
| Element enclosingElement = element.getEnclosingElement(); | ||
| if (enclosingElement instanceof PackageElement) { |
There was a problem hiding this comment.
Any way to do this without instanceof? My read of the docs is that a single class is allowed to implement multiple types.
There was a problem hiding this comment.
Good point, I changed it to use a visitor. LMK if the visitUnknown part looks weird though.
| ErrorType errorType = | ||
| new DeclaredTypeAsErrorType(getTypes().getDeclaredType(getElement(Set.class))); | ||
| assertThat(TypeName.get(errorType)).isEqualTo(ClassName.get(Set.class)); | ||
| @Test public void errorTypes() { |
swankjesse
approved these changes
May 16, 2018
|
Will release as 1.11.1. |
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.