Add JDK 11 and load install-jdk.sh on-the-fly #629
Conversation
sormuras
force-pushed
the
load-install-jdk-on-the-fly
branch
from
531ea45
to
1a0de16
Compare
|
Allow JDK 11 builds to fail. |
|
With the GA of JDK 10 -- http://jdk.java.net/10/ -- the PR needs (a) to be modified a bit and (b) to be merged. There's no longer an "Oracle JDK 10 build"... Regarding (a): |
sormuras
force-pushed
the
load-install-jdk-on-the-fly
branch
from
1a0de16
to
e9da3e1
Compare
|
@JakeWharton / @swankjesse -- next build on Travis CI is expected to fail, if this PR is not merged. |
|
@JakeWharton / @swankjesse As expected the build triggered by the merge six days ago failed on Travis CI running on JDK 10. |
.travis.yml
Outdated
|
|
||
| before_install: | ||
| - unset _JAVA_OPTIONS | ||
| - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh |
There was a problem hiding this comment.
Can we pin this to a SHA rather than a branch?
There was a problem hiding this comment.
You'll lose the auto-update feature/service I provide. Oracle/Java.net keep changing the URLs now and then...
The manual loading of install-jdk.sh might be superseded by the integration in Travis CI, soon. See travis-ci/travis-build#1347 for details.
There was a problem hiding this comment.
Just released 1.0.1. So we may pin it to:
https://github.com/sormuras/bach/raw/1.0.1/install-jdk.sh
Support JDK 10 and 11-ea
sormuras
force-pushed
the
load-install-jdk-on-the-fly
branch
from
e9da3e1
to
3c68a05
Compare
|
@JakeWharton Force-pushed a pinned version and removed the outdated |
|
@swankjesse All the red crosses at Travis-CI hurt my testing guts... ❌ Any chance to make the builds happy again by merging this PR? ✔️ |
|
Thanks! |
|
You're welcome! |
No more updates needed when new EA feature builds are published or paths to existing archives are changed.