MembersInjector's constructor has wrong parameter order when base class with @Inject fields is in another module

[matejdro]

When:

1. You have a class and subclass that both inject something with @Inject
2. Both of those classes are in separate modules that only run anvil (with factory generation)
3. You attempt to get a MembersInjector for that class

Build will fail with incompatible types exception. It seems like the order of parameters in MembersInjector generated by Anvil is not the same as expected by Dagger.

Steps to reproduce:

Run this test: matejdro@df9e78a

OR

1. Checkout https://github.com/matejdro/issues/tree/anvil-field-injection-subclass
2. Run ./gradlew assembleDebug

This situation seems weirdly specific at first, but getting MembersInjector strategy is used by Whestone to allow activity injection. Concretely, this bug means that we cannot have an activity where both actual activity and its parent class inject things independently.

[matejdro]

This looks like a bug on the Kotlin side?

When list of fields is fetched in
com.squareup.anvil.compiler.codegen.dagger.DaggerGenerationUtils#declaredMemberInjectParameters, properties will list properties in the wrong order.

This only happens when base class is in another module and this = ClassReference.Descriptor. When class is in the same module, this = ClassReference.Psi the order is correct.

I would appreciate some help with reporting this upstream to Kotlin, since I'm not sure what exactly is happening behind the scenes to make a proper report.

By the way, I made a simple test for this issue here for even easier reproduce: matejdro@df9e78a