Support invariant and covariant type parameters properly. #391
+73
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vRallev
changed the title
christiandeange
approved these changes
Oct 18, 2021
|
|
||
| other as AssistedService | ||
|
|
||
| if (list.size != other.list.size) return false |
There was a problem hiding this comment.
Comparing only size seems weird but I guess this is just an example
There was a problem hiding this comment.
Yeah, I was lazy...
There was a problem hiding this comment.
Wouldn't if (list != other.list) return false work just as easily? lol
| val assistedServiceInstance = factoryImplClass.declaredMethods | ||
| .filterNot { it.isStatic } | ||
| .single { it.name == "create" } | ||
| .invoke(factoryImplInstance, listOf<Class<out String>>()) |
There was a problem hiding this comment.
nit: replace listOf<Class<out String>>() with a single re-used val list = listOf<Class<out String>>() instance? Perhaps with some items in it too
There was a problem hiding this comment.
This isn't really necessary as it would only test my fake implementation for equals() and hashCode().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388