Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParserError if nested explain #781

Merged
merged 1 commit into from Dec 29, 2022
Merged

ParserError if nested explain #781

merged 1 commit into from Dec 29, 2022

Conversation

Jefffrey
Copy link
Contributor

Closes #744

Return ParserError during parsing if nested explain found

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3797769320

  • 12 of 14 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 85.975%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 12 14 85.71%
Totals Coverage Status
Change from base Build 3795207804: 0.0008%
Covered Lines: 13014
Relevant Lines: 15137
💛 - Coveralls

alamb
alamb approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit cf3fe64 into sqlparser-rs:main Dec 29, 2022
@alamb
Copy link
Collaborator

alamb commented Dec 29, 2022

Thank you for the contribution @Jefffrey

@Jefffrey Jefffrey deleted the 744_nested_explain branch December 29, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return an error when the SQL query contains nested Explain
3 participants
@Jefffrey @coveralls @alamb