Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs and add examples for Visitor #778

Merged
merged 4 commits into from Dec 29, 2022
Merged

Improve docs and add examples for Visitor #778

merged 4 commits into from Dec 29, 2022

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Dec 28, 2022 •
edited

Follow on to #765

@alamb alamb mentioned this pull request Dec 28, 2022
Merged
@alamb
Copy link
Collaborator Author

alamb commented Dec 28, 2022

cc @tustvold

@coveralls
Copy link

coveralls commented Dec 28, 2022 •
edited

Pull Request Test Coverage Report for Build 3800963580

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.033%
Totals Coverage Status
Change from base Build 3800667466: 0.0%
Covered Lines: 13102
Relevant Lines: 15229
💛 - Coveralls

@alamb
Copy link
Collaborator Author

alamb commented Dec 29, 2022

@tustvold do you have time to review this PR? I hope to merge this later today / make a release

tustvold
tustvold approved these changes Dec 29, 2022
View reviewed changes
src/ast/visitor.rs Outdated Show resolved Hide resolved
src/ast/visitor.rs
/// let mut visited = vec![];
/// visit_relations(&statements, |relation| {
/// visited.push(format!("RELATION: {}", relation));
/// ControlFlow::<()>::Continue(())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised you need to type hint this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, me too -- I think it is because the return value is not used

src/ast/visitor.rs Outdated Show resolved Hide resolved
alamb and others added 3 commits December 29, 2022 08:47
@alamb @tustvold
Update src/ast/visitor.rs
5896ca6 
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@alamb @tustvold
Update src/ast/visitor.rs
455801f 
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@alamb
Merge remote-tracking branch 'upstream/main' into alamb/docs_examples…
3bd1d27 
…_visitor
@alamb alamb merged commit 87df09b into sqlparser-rs:main Dec 29, 2022
@alamb alamb deleted the alamb/docs_examples_visitor branch December 29, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alamb @coveralls @tustvold