Fix cargo docs / warnings and add CI check
#777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3795248432
💛 - Coveralls |
alamb
commented
Dec 29, 2022
| @@ -11,9 +11,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| //! This module defines | |||
| //! 1) a list of constants for every keyword that | |||
| //! can appear in [Word::keyword]: | |||
There was a problem hiding this comment.
This appears to be referring to some older version of the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was bothering me when working on tests / docs for visitor
Rationale:
Fix all
cargo docwarning, and add CI check to avoid errors in the futureExample CI test failure: https://github.com/sqlparser-rs/sqlparser-rs/actions/runs/3795223499/jobs/6454127069