Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize parsing optional keywords, improve comments #773

Merged
merged 1 commit into from Dec 28, 2022
Merged

Standardize parsing optional keywords, improve comments #773

merged 1 commit into from Dec 28, 2022

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Dec 28, 2022

I was somewhat confused about this pattern in #767 so I added some comments to improve the code.

I also removed support for parsing ONLY from ALTER INDEX added by @devgony in #767 (comment)

@alamb alamb mentioned this pull request Dec 28, 2022
Merged
2 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3794402341

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0009%) to 86.387%
Totals Coverage Status
Change from base Build 3794352929: -0.0009%
Covered Lines: 13003
Relevant Lines: 15052
💛 - Coveralls

@alamb alamb merged commit b1a000f into sqlparser-rs:main Dec 28, 2022
@alamb alamb deleted the alamb/optional_keywords branch December 28, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alamb @coveralls