feat: dollar-quoted strings support #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3799814922
💛 - Coveralls |
alamb
reviewed
Dec 28, 2022
There was a problem hiding this comment.
Thank you @vasilev-alex
The basic idea looks good to me. I think with some tests it would be 👍
|
Marking as draft to signify it is waiting on tests -- please mark as ready to review when it is |
vasilev-alex
force-pushed
the
dollar-quoted-strings
branch
from
6f292b4
to
5dd6e3e
Compare
alamb
reviewed
Dec 28, 2022
alamb
approved these changes
Dec 29, 2022
| if prev == Some('$') { | ||
| if ch == '$' { | ||
| chars.next(); | ||
| is_terminated = true; |
| tag: None, | ||
| value: "Foo$Bar".into(), | ||
| })), | ||
| alias: Ident { |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was the
DoubleDollarQuotingtoken, and it was used only in the context of functions. But technically, dollar-quoting is another way to present strings.e.g.
That's why I think it's reasonable to introduce the
DollarQuotedStringtoken, which can hold such string values and their optional tag names.I have not added any tests yet but will do it if otherwise, it looks ok.
Closes #698