Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize locking clause #759

Merged
merged 2 commits into from Dec 13, 2022
Merged

Conversation

audunska
Copy link
Contributor

Postgres supports more generalized locking clauses, for example: FOR UPDATE OF <table_name> SKIP LOCKED

also, multiple locking clauses. Generalize the parser to support these.

This might be a breaking change, since we're adding new keywords SKIP , LOCKED and NOWAIT. What's the policy on that?

Postgres supports more generalized locking clauses, for example:
FOR UPDATE OF <table_name> SKIP LOCKED

also, multiple locking clauses. Generalize the parser to support these.
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @audunska -- I looked at

https://www.postgresql.org/docs/current/sql-select.html

And this PR appears to implement that grammar 👍

This might be a breaking change, since we're adding new keywords SKIP , LOCKED and NOWAIT. What's the policy on that?

It is fine and expected -- we release new versions that do not get automatically semver updated.

@alamb
Copy link
Collaborator

alamb commented Dec 13, 2022

For some reason the CI checks did not run on this PR . I took the liberty of merging up from main to see if I can get them to run

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3689789223

  • 119 of 119 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.372%

Totals Coverage Status
Change from base Build 3689610291: 0.1%
Covered Lines: 12650
Relevant Lines: 14646

💛 - Coveralls

@alamb alamb merged commit fb02344 into sqlparser-rs:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants