Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support create function definition with $$ #755

Merged
merged 2 commits into from Dec 13, 2022

Conversation

zidaye
Copy link
Contributor

@zidaye zidaye commented Dec 8, 2022

close #754

@coveralls
Copy link

coveralls commented Dec 8, 2022

Pull Request Test Coverage Report for Build 3647669410

  • 43 of 52 (82.69%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 86.256%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 4 7 57.14%
src/parser.rs 14 20 70.0%
Totals Coverage Status
Change from base Build 3641238188: -0.02%
Covered Lines: 12577
Relevant Lines: 14581

💛 - Coveralls

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @zidaye

I verified this is in the postgresql dialect: https://www.postgresql.org/docs/current/sql-createfunction.html 👍

@alamb alamb merged commit 6c54519 into sqlparser-rs:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Postgres Create Function]: does not support $$
3 participants