Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake - allow the "type" key #750

Merged
merged 1 commit into from Dec 6, 2022
Merged

Snowflake - allow the "type" key #750

merged 1 commit into from Dec 6, 2022

Conversation

yuval-illumex
Copy link
Contributor

In continue of 693 , the parser parse key:value syntax of snowflake. this pr adds support when they key is "type".

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3629417764

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 86.31%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_snowflake.rs 14 16 87.5%
Totals Coverage Status
Change from base Build 3623452535: 0.001%
Covered Lines: 12546
Relevant Lines: 14536
💛 - Coveralls

alamb
alamb approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuval-illumex

@alamb alamb merged commit 01fd20f into sqlparser-rs:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuval-illumex @coveralls @alamb