Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative test for except clause on wildcards #746

Merged
merged 1 commit into from Dec 7, 2022
Merged

Add negative test for except clause on wildcards #746

merged 1 commit into from Dec 7, 2022

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Dec 5, 2022

Implement suggestions on #745

Specifically:

  1. Remove seemingly unnecessary test feat: add support for except clause on wildcards #745 (comment)
  2. Add negative test for empty list

@alamb
Copy link
Collaborator Author

alamb commented Dec 5, 2022

cc @AugustoFKL

@alamb alamb mentioned this pull request Dec 5, 2022
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3623174589

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 86.379%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_bigquery.rs 1 2 50.0%
Totals Coverage Status
Change from base Build 3623155769: -0.01%
Covered Lines: 12436
Relevant Lines: 14397
💛 - Coveralls

@alamb alamb merged commit 650c53d into sqlparser-rs:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustoFKL AugustoFKL AugustoFKL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alamb @coveralls @AugustoFKL