Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for except clause on wildcards #745

Merged
merged 1 commit into from Dec 5, 2022
Merged

feat: add support for except clause on wildcards #745

merged 1 commit into from Dec 5, 2022

Conversation

AugustoFKL
Copy link
Contributor

Closes: #687

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3604678113

  • 85 of 91 (93.41%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 86.392%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 17 20 85.0%
src/parser.rs 25 28 89.29%
Totals Coverage Status
Change from base Build 3596550023: 0.03%
Covered Lines: 12443
Relevant Lines: 14403
💛 - Coveralls

alamb
alamb approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @AugustoFKL

I had a question about one of the tests and it would probably be good to have a negative case for SELECT * EXCEPT () FROM data but I think both of those can be added as a follow on PR and I want to merge this one in so I can include it in the release I am preparing.

I'll write some

tests/sqlparser_bigquery.rs
_ => unreachable!(),
};

match bigquery_and_generic().verified_stmt("SELECT * EXCEPT (col1, col2) FROM _table") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this test is checking that is not covered by "SELECT * EXCEPT (department_id, employee_id) FROM employee_table" above

@alamb alamb merged commit b368851 into sqlparser-rs:main Dec 5, 2022
@alamb alamb mentioned this pull request Dec 5, 2022
Merged
@alamb
Copy link
Collaborator

alamb commented Dec 5, 2022 •
edited

Proposed follow on: #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SELECT * EXCEPT(col1, col2, ...) for BigQueryDialect
3 participants
@AugustoFKL @coveralls @alamb