New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: avoid using `unreachable!` when parsing semi/anti join #738

Merged

Dandandan merged 1 commit into sqlparser-rs:main from alamb:alamb/no_unreachable

Nov 30, 2022

Collaborator

alamb commented Nov 30, 2022

Avoid unreachable! as requested by @AugustoFKL on https://github.com/sqlparser-rs/sqlparser-rs/pull/723/files#r1028287840


          Cleanup: avoid using unreachable! when parsing semi/anti join

coveralls commented Nov 30, 2022

Pull Request Test Coverage Report for Build 3585873667

5 of 14 (35.71%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 86.269%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/parser.rs	5	14	35.71%

Files with Coverage Reduction	New Missed Lines	%
src/parser.rs	2	83.53%

Totals
Change from base Build 3585842714:	-0.06%
Covered Lines:	12069
Relevant Lines:	13990

💛 - Coveralls

Dandandan approved these changes

View reviewed changes

Dandandan merged commit bd35273 into sqlparser-rs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment