Snowflake - Add support in CLUSTER BY when creating Materialised View #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3573835180
💛 - Coveralls |
alamb
reviewed
Nov 30, 2022
There was a problem hiding this comment.
As always, thank you @yuval-illumex 👍 Really appreciate all the help here
| @@ -1114,6 +1114,7 @@ pub enum Statement { | |||
| columns: Vec<Ident>, | |||
| query: Box<Query>, | |||
| with_options: Vec<SqlOption>, | |||
| cluster_by: Vec<Ident>, | |||
There was a problem hiding this comment.
https://docs.snowflake.com/en/sql-reference/sql/create-materialized-view.html says
[ CLUSTER BY ( <expr1> [, <expr2> ... ] ) ]
But this PR has cluster by as only columns (not expressions).
I am fine with merging this as is but I wonder if you want to support the more general syntax?
alamb
approved these changes
Nov 30, 2022
|
We can make the "Expr" change in a follow on PR if desired. For now I think this is an improvement over main so I am merging it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to snowflake docs, The last optional parameter is CLUSTER BY