Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update on conflict with condition #735

Merged
merged 1 commit into from Nov 30, 2022

Conversation

zidaye
Copy link
Contributor

@zidaye zidaye commented Nov 29, 2022

@baoyachi
Copy link

LGTM

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zidaye

/// Column assignments
pub assignments: Vec<Assignment>,
/// WHERE
pub selection: Option<Expr>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is to call this where to match the SQL more closely -- I will make this change in a follow on PR

Copy link
Collaborator

@alamb alamb Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now I see the name selection is consistent with the rest of this crate (e.g.

selection: Option<Expr>,
)

I will not make any other changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3573700071

  • 46 of 48 (95.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.378%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 8 10 80.0%
Totals Coverage Status
Change from base Build 3568725328: 0.02%
Covered Lines: 11921
Relevant Lines: 13801

💛 - Coveralls

@alamb alamb merged commit 042effd into sqlparser-rs:main Nov 30, 2022
@alamb
Copy link
Collaborator

alamb commented Nov 30, 2022

Thanks again @zidaye and @baoyachi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants