Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle nested comments #726

Merged
merged 1 commit into from Nov 30, 2022
Merged

fix: handle nested comments #726

merged 1 commit into from Nov 30, 2022

Conversation

yang-han
Copy link
Contributor

Make the tokenize_multiline_comment() able to handle nested comments

@lmatz lmatz mentioned this pull request Nov 22, 2022
Merged
2 tasks
AugustoFKL
AugustoFKL approved these changes Nov 26, 2022
View reviewed changes
Copy link
Contributor

@AugustoFKL AugustoFKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3522588584

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.297%
Totals Coverage Status
Change from base Build 3448124733: 0.02%
Covered Lines: 11821
Relevant Lines: 13698
💛 - Coveralls

alamb
alamb approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yang-han and @AugustoFKL for the review

@alamb alamb merged commit e22aa78 into sqlparser-rs:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@AugustoFKL AugustoFKL AugustoFKL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yang-han @coveralls @alamb @AugustoFKL