Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Supports updating valid column names whose names are the same as… #725

Merged
merged 2 commits into from Nov 27, 2022
Merged

fix: Supports updating valid column names whose names are the same as… #725

merged 2 commits into from Nov 27, 2022

Conversation

step-baby
Copy link
Contributor

… keywords

#615

@coveralls
Copy link

coveralls commented Nov 22, 2022

Pull Request Test Coverage Report for Build 3521521194

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.293%

Totals Coverage Status
Change from base Build 3448124733: 0.02%
Covered Lines: 11804
Relevant Lines: 13679

💛 - Coveralls

Copy link
Contributor

@AugustoFKL AugustoFKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, if the tests didn't break, looks OK... Not sure how this can affect other projects, though.

@alamb

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this behavior is consistent with postgres as well:

postgres=# create table foo(value int);
CREATE TABLE
postgres=# update foo set value = 5;
UPDATE 0
postgres=# 

@alamb
Copy link
Collaborator

alamb commented Nov 27, 2022

Thanks @step-baby

@alamb alamb merged commit 10652b6 into sqlparser-rs:main Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants